Ticket #55 (closed defect: fixed)

Opened 3 years ago

Last modified 22 months ago

correlation analysis

Reported by: willaume@… Owned by: regis.lebrun@…
Priority: minor Milestone: openturns-0.13.0
Component: documentation Version: 0.11.1
Keywords: PCC, SRC, PRCC, SRRC Cc:

Description

I don't understand the use of the methods :

  • .PCC
  • .PRCC
  • .SCC
  • .SRCC

The first two methods give an error message which seems to be a bug. The second two methods give another error message. (see attached files)

Attachments

PCC.py (2.4 KB) - added by willaume@… 3 years ago.
PRCC.py (2.4 KB) - added by willaume@… 3 years ago.
SCC.py (2.4 KB) - added by willaume@… 3 years ago.
SRCC.py (2.4 KB) - added by willaume@… 3 years ago.
pdebuild.log (1.6 MB) - added by conty 3 years ago.
Ubuntu Gutsy Gibbon amd64 compilation log file.

Change History

Changed 3 years ago by willaume@…

Changed 3 years ago by willaume@…

Changed 3 years ago by willaume@…

Changed 3 years ago by willaume@…

comment:1 Changed 3 years ago by anonymous

It follows from the definition of PCC and PRCC taht these quantities cannot be computed if the dimension of the input sample is not at least equal to 2, see OpenTURNS_ReferenceGuide, section C'. Nevertheless, OpenTURNS should complain about the wrong input sample dimension and it doesn't, which is a bug. It will be fixed in the next maintenance release and the next release.

For the two files SCC.py and SRCC.py, there is a mispelling between SCC (does not exist) and SRC (Standard Regression Coefficient), and between SRCC (does not exist) and SRRC (Standard Rank Regrassion Coefficient).

comment:2 Changed 3 years ago by willaume@…

For the two files SCC.py and SRCC.py, there is a mispelling between SCC
(does not exist) and SRC (Standard Regression Coefficient), and between
SRCC (does not exist) and SRRC (Standard Rank Regrassion Coefficient).

So there is a bug in the TUI user manual.

comment:3 Changed 3 years ago by regis.lebrun@…

  • keywords PCC, SRC, PRCC, SRRC added
  • priority changed from unspecified to minor
  • component changed from library to documentation

Yes: there is a bug in the documentation. By the way, it is clearly stated in the exact same documentation that the dimension of the firt sample must be > 1 for PCC and PRCC ;-), and it is also (wrongly) stated that the same restriction occurs for SRC and SRRC. Nevertheless, I added a test to CorrelationAnalysis class and I requalify this ticket as a documentation issue.

comment:4 Changed 3 years ago by willaume@…

In my documentation I have no sign ">", just a reverse "?".

comment:5 follow-ups: ↓ 6 ↓ 7 Changed 3 years ago by regis.lebrun@…

Something bad during the LaTeX compilation? Can you give the pdflatex compilation log?

comment:6 in reply to: ↑ 5 Changed 3 years ago by conty

  • status changed from new to assigned

Replying to regis.lebrun@eads.net:

Something bad during the LaTeX compilation? Can you give the pdflatex compilation log?

Users from Phimeca Engineering use Debian packages, they don't have any compilation logs. As maintener, I can deliver you the compilation log of building package process. Unfortunately I have removed all logs of 0.11.1 building process but the 0.11.2 is coming (very) soon and I will keep them.

comment:7 in reply to: ↑ 5 Changed 3 years ago by conty

  • owner changed from conty to regis.lebrun@…
  • status changed from assigned to new

Ubuntu/Gutsy in amd64 compilation log files attached.

Changed 3 years ago by conty

Ubuntu Gutsy Gibbon amd64 compilation log file.

comment:8 Changed 3 years ago by conty

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to openturns-0.11.3

comment:9 Changed 3 years ago by anne.dutfoy@…

  • status changed from closed to reopened
  • resolution fixed deleted

I fixed the typo in the documentation concerning these methods.

comment:10 Changed 3 years ago by regis.lebrun@…

  • status changed from reopened to closed
  • resolution set to fixed

comment:11 Changed 22 months ago by willaume@…

  • status changed from closed to reopened
  • resolution fixed deleted

In the TUI user manual I downloaded a few minutes ago :

  • the sample 1 for PCC and PRCC methods is still specified of dimension greater or equal to 1.
  • SRCC is not corrected

comment:12 Changed 22 months ago by regis.lebrun@…

  • status changed from reopened to closed
  • resolution set to fixed
  • milestone changed from openturns-0.11.3 to openturns-0.13.0

This time, it is ok. I also updated the online documentation.

Régis

Note: See TracTickets for help on using tickets.